Add support for Totems #1188
Merged
Add support for Totems #1188
+118
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'totem' flag was missing for the damaging part of the skill
`addFlags` functionality was accidentally broken in PathOfBuildingCommunity#62 because `mainSkillFlags` and `calcSkillFlags` variables were introduced but seemingly later made redundant to use the original `skillFlags`. However the `addFlags` section still checked the old variables which were now `nil`. This wasn't a problem until now, because the PoE2 skills had not used `addFlags` yet.
`CalcSetup` previous added +1 to "ActiveTotemLimit" as a base, but totem skills in PoE2 always come with "base_number_of_totems_allowed" values, which led to the values always being 1 too high
This fixes previous problems that were caused by totem skills consisting of multiple parts, such as inability to get correct skillTotemId and level requirement for the "active" portion of a totem skill. The skill (or support) that provides the baseTotem data is now identified within `CalcActiveSkill` Examples: - "Shockwave Totem" -> "Wave" would not show correct totem stats - "Sunder" attached to "Ancestral Warrior Totem" would not show any totem stats at all
6 tasks
added 2 commits
September 2, 2025 16:08
Adds support for a few stats on mortar cannon and ancestral totem too
LocalIdentity
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #502 . (Will have to check after 0.3.0 because behavior will change)
Description of the problem being solved:
PoE2 treats the active portion of totem skills as separate "totemified" skills, rather than additional stat sets of the same skill. This lead to several problems because totem base stats are only available on the "base" skill (which in case of "Ancestral Warrior Totem" is on entirely different gem, as well)
List of fixed issues:
levelRequirement = 0leading to crashes when trying to determine totem level in some casesskillTotemIdwas not working because the stat was not present on the "totemified" skilltotemflag{ "base_number_of_totems_allowed", 1 }, making the"Base"mod inCalcSetupredundantAdditional Notes:
alt_attack_containerbehavior which made totems have their own weapon-independent attack stats. Since this behavior will be changed in 0.3.0 in a few days, it makes no sense to include here, but I have it saved somewhere in case we ever have to useralt_attack_containerfor something else.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/qaitk0qc
Before screenshot:
No totem stats
No increase from totem damage (Sunder on Ancestral Warrior Totem)
After screenshot:
now with totem stats
Increase from totem damage works now (Sunder on Ancestral Warrior Totem)
